apollo-client/src/main/java/com/ctrip/framework/apollo/internals/AbstractConfig.java (1)

113-123: ⚠️ Potential issue | 🟠 Major

m_interestedKeys/m_interestedKeyPrefixes removal still uses equals, inconsistent with identity-based m_listeners.

When two listeners are equal-but-not-identical (the exact scenario this PR fixes), m_interestedKeys.remove(listener) on line 115 uses equals-based lookup on the ConcurrentHashMap, so removing either listener deletes the shared map entry for both. The surviving listener then has no entry in m_interestedKeys, causing isConfigChangeListenerInterested to treat it as interested in all keys — a silent broadening of its subscription scope.

The same issue applies to addChangeListener: m_interestedKeys.put(listener2, ...) overwrites the entry keyed by listener1 (since ConcurrentHashMap uses equals), so listener1's interested-key set is silently replaced by listener2's.

Consider switching these maps to an IdentityHashMap (wrapped with Collections.synchronizedMap for thread safety) to match the identity semantics used for m_listeners.

Proposed fix sketch

-  private final Map<ConfigChangeListener, Set<String>> m_interestedKeys = Maps.newConcurrentMap();
-  private final Map<ConfigChangeListener, Set<String>> m_interestedKeyPrefixes = Maps.newConcurrentMap();
+  private final Map<ConfigChangeListener, Set<String>> m_interestedKeys =
+      Collections.synchronizedMap(new IdentityHashMap<>());
+  private final Map<ConfigChangeListener, Set<String>> m_interestedKeyPrefixes =
+      Collections.synchronizedMap(new IdentityHashMap<>());

And in removeChangeListener, move the map removals inside the identity check so only the matched instance's entries are cleaned up:

   public boolean removeChangeListener(ConfigChangeListener listener) {
-    m_interestedKeys.remove(listener);
-    m_interestedKeyPrefixes.remove(listener);
     for (ConfigChangeListener addedListener : m_listeners) {
       if (addedListener == listener) {
+        m_interestedKeys.remove(addedListener);
+        m_interestedKeyPrefixes.remove(addedListener);
         return m_listeners.remove(addedListener);
       }
     }
     return false;
   }